linux-kernel - Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1236318629.7260.120.camel@pasglop>
Date:	Fri, 06 Mar 2009 16:50:29 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Gaudenz Steinlin <gaudenz@...iologie.ch>
Cc:	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms"
 breaks resume from RAM on PowerBook


> As already said in an earlier mail, this does not make any difference. I
> now ran some more tests:
> 
> -> with ppc32_defconfig: same results, resume with your commit is
>    broken, I did not yet test if reverting the commit fixes resume.
>    Please tell me if you are interested in this result.
> -> with a minimal config (attached): resume does not work at all with or 
>    without your commit. I suspect this is another bug with the same
>    symptoms. 
> 
> If you have any ideas, I would be happy to do further tests. I could
> also send you my compiles kernel (as a Debian package or a tar file) or
> you could send me your working kernel image to see if it also works for
> me. 

I think that .config fails due to the lack of CPU_FREQ support. I think
I remember that specifically this powerbook model boots at low speed and
fails to resume if not suspended at high speed. The cpufreq driver for
powermacs knows about that and ramps up the frequency before suspend.

Can you give that a try ?

In fact I verified on mine that your minimum config fails the same way
you described but it works when I re-enable cpufreq support.

We might want to do something to warn people in this situation.. maybe
the sleep code can somewhat verify that cpufreq is there.

Cheers,
Ben.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/