linux-kernel - Re: [PATCH] mtd: plat_nand: add platform probe/remove callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090306132438.e55fef0d.akpm@linux-foundation.org>
Date:	Fri, 6 Mar 2009 13:24:38 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"hartleys" <hartleys@...ionengravers.com>
Cc:	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	alex@...riz.org.uk, vitalywool@...il.com
Subject: Re: [PATCH] mtd: plat_nand: add platform probe/remove callbacks

On Thu, 5 Mar 2009 18:58:12 -0500
"hartleys" <hartleys@...ionengravers.com> wrote:

> From: "hartleys" <hartleys@...ionengravers.com>

You might want to change your email setup so that the above reads "H
Hartley Sweeten <hsweeten@...ionengravers.com>" or whatever.  Because
most patch-merging people's tools will end up marking this commit as
being from someone called "hartleys".

Alternatively, put an explicit From: line at the top of the changelog.

> To: <linux-kernel@...r.kernel.org>
> Cc: <linux-mtd@...ts.infradead.org>, "Alexander Clouter" <alex@...riz.org.uk>, "Andrew Morton" <akpm@...ux-foundation.org>, <vitalywool@...il.com>
> Subject: [PATCH] mtd: plat_nand: add platform probe/remove callbacks
> Date: Thu, 5 Mar 2009 18:58:12 -0500
> 
> Add optional probe and remove callbacks to the plat_nand driver.
> 
> Some platforms may require additional setup, such as configuring
> the memory controller, before the nand device can be accessed.
> This patch provides an optional callback to handle this setup as
> well as a callback to teardown the setup.
> 
> This patch was originally submitted to linux-mtd but it was
> suggested I post it here for a broader review.

Looks OK to me, but I'm an MTD ignoramus.

> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Tested-By: Alexander Clouter <alex@...riz.org.uk>
> 
> ---
> 
> diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
> index 75f9f48..600fbe9 100644

The patch was quite wordwrapped.  Please fix your email client for next
time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/