[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1236374767.7260.152.camel@pasglop>
Date: Sat, 07 Mar 2009 08:26:07 +1100
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Gaudenz Steinlin <gaudenz@...iologie.ch>
Cc: linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms"
breaks resume from RAM on PowerBook
On Fri, 2009-03-06 at 12:41 +0100, Gaudenz Steinlin wrote:
>
> Adding this fixes the bug. Apparently the PCI core does not fully
> restore the state. Before your suggestions I also tried to find out
> which part of your commit breaks resume and I found out that if I
> reinsert the parts to save and restore the pci configuration the bug
> is
> fixed. It seems that somehow the PCI coniguration is not fully
> restored [1].
Ok, well, I though it would be due to some upstream changes but it's
possible that I either mis-read those changes or they got themselves
changed in some subtle way after I did that commit :-)
I still find it fascinating that it doesn't break for me here since it
is effectively the same machine model !
I'll do a patch fixing that but it will have to wait for monday.
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists