lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 6 Mar 2009 17:49:13 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Bryan Wu <cooloney@...nel.org>, alan@...rguk.ukuu.org.uk,
	linux-kernel@...r.kernel.org, sonic.zhang@...log.com
Subject: Re: [PATCH 04/18] Blackfin Serial Driver: Change hardware flowcontrol 
	from poll to interrupt driven.

On Fri, Mar 6, 2009 at 17:38, Andrew Morton wrote:
> On Fri,  6 Mar 2009 14:42:46 +0800 Bryan Wu wrote:
>> From: Sonic Zhang <sonic.zhang@...log.com>
>>
>> Only CTS bit is affected.
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>
> Another completely useless changelog.

the summary, while brief, describes the change: the flowcontrol is
currently implemented by polling, but this changes it to an interrupt
based system

> Your [PATCH 00/18] email described all these patches as
> needed-in-2.6.29 bugfixes.  As far as I can tell (based on almost zero
> information), this patch is not a bugfix.

because the current implementation is polling (busy waiting), the
kernel will basically hang when the remote asserts hardware
flowcontrol pins.  if this is only asserted for short periods (less
than 1 char time), then it's not really noticed ... but it still
destroys latencies.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ