linux-kernel - Re: [tip:perfcounters/core] x86: perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1236545948.22914.3648.camel@twins>
Date:	Sun, 08 Mar 2009 21:59:08 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	jaswinder@...nel.org, tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/core] x86: perf_counter cleanup

On Sun, 2009-03-08 at 15:52 +0000, Jaswinder Singh Rajput wrote:
> Commit-ID:  e255357764f92afcafafbd4879b222b8c752065a
> Gitweb:     http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
> Author:     "Jaswinder Singh Rajput" <jaswinder@...nel.org>
> AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
> Commit:     Ingo Molnar <mingo@...e.hu>
> CommitDate: Sun, 8 Mar 2009 16:26:50 +0100
> 
> x86: perf_counter cleanup
> 
> Remove unused variables and duplicate header file.

Why did you commit this?

Until someone from AMD steps up and either tells us they're going to be
48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd
rather try and get the dynamic thing working.

> Signed-off-by: Jaswinder Singh Rajput <jaswinder@...nel.org>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> 
> ---
>  arch/x86/kernel/cpu/perf_counter.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
> index 1df4210..155bc3c 100644
> --- a/arch/x86/kernel/cpu/perf_counter.c
> +++ b/arch/x86/kernel/cpu/perf_counter.c
> @@ -17,7 +17,6 @@
>  #include <linux/kdebug.h>
>  #include <linux/sched.h>
>  
> -#include <asm/perf_counter.h>
>  #include <asm/apic.h>
>  
>  static bool perf_counters_initialized __read_mostly;
> @@ -954,9 +953,6 @@ static struct pmc_x86_ops *pmc_intel_init(void)
>  
>  static struct pmc_x86_ops *pmc_amd_init(void)
>  {
> -	u64 old;
> -	int bits;
> -
>  	nr_counters_generic = 4;
>  	nr_counters_fixed = 0;
>  	counter_value_mask = 0x0000FFFFFFFFFFFFULL;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/