linux-kernel - Re: [tip:perfcounters/core] x86: perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B432A4.7010807@zytor.com>
Date:	Sun, 08 Mar 2009 14:03:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	linux-kernel@...r.kernel.org, mingo@...hat.com,
	jaswinder@...nel.org, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/core] x86: perf_counter cleanup

Peter Zijlstra wrote:
> On Sun, 2009-03-08 at 15:52 +0000, Jaswinder Singh Rajput wrote:
>> Commit-ID:  e255357764f92afcafafbd4879b222b8c752065a
>> Gitweb:     http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
>> Author:     "Jaswinder Singh Rajput" <jaswinder@...nel.org>
>> AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
>> Commit:     Ingo Molnar <mingo@...e.hu>
>> CommitDate: Sun, 8 Mar 2009 16:26:50 +0100
>>
>> x86: perf_counter cleanup
>>
>> Remove unused variables and duplicate header file.
> 
> Why did you commit this?
> 
> Until someone from AMD steps up and either tells us they're going to be
> 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd
> rather try and get the dynamic thing working.
> 

That would be good, but there really is absolutely no reason to leave in
variables which are unused in the current code and therefore give a gcc
warning.  It's not like adding new declaration is hard.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/