linux-kernel - Re: [patch -mm] cpusets: add memory_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903081438550.30551@chino.kir.corp.google.com>
Date:	Sun, 8 Mar 2009 14:51:58 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Matt Mackall <mpm@...enic.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Paul Menage <menage@...gle.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch -mm] cpusets: add memory_slab_hardwall flag

On Sun, 8 Mar 2009, Matt Mackall wrote:

> > For slob, if the page from the slob list is not from an allowable node,
> > we continue to scan for an appropriate slab.  If none can be used, a new
> > slab is allocated.
> 
> Looks fine to me, if a little expensive.

Is that your acked-by? :)

It's not expensive for cpusets that do not set memory_slab_hardwall, which 
is disabled by default, other than some cacheline polluting.  If the 
option is set, then the performance penalty is described in the 
documentation and should be assumed by the user.

We currently have a couple different ways to check for a task's cpuset 
options:

 - per-task flags such as PF_SPREAD_PAGE and PF_SPREAD_SLAB used in the
   hotpath, and

 - rcu dereferencing current's cpuset and atomically checking a cpuset
   flag bit.

It would be nice to unify these to free up some task flag bits.

> We'll be needing SLQB support
> though.
> 

Yeah, I'd like to add the necessary slqb support from Pekka's git tree but 
this patch depends on 
cpusets-replace-zone-allowed-functions-with-node-allowed.patch in -mm, so 
we'll need to know the route by which this should be pushed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/