linux-kernel - Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903092219.37414.rjw@sisk.pl>
Date:	Mon, 9 Mar 2009 22:19:37 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alex Chiang <achiang@...com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"linux-pci" <linux-pci@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path

On Monday 09 March 2009, Alex Chiang wrote:
> Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
> added a kfree of the driver private data in pcie_port_device_remove
> but forgot to remove the old kfree from pcie_portdrv_remove.

Ah, sorry for that, it resulted in quite a lot of debugging work for you. :-(

> Signed-off-by: Alex Chiang <achiang@...com>

Acked-by; Rafael J. Wysocki <rjw@...k.pl>

> ---
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index a6fee6c..f2368b1 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,
>  static void pcie_portdrv_remove (struct pci_dev *dev)
>  {
>  	pcie_port_device_remove(dev);
> -	kfree(pci_get_drvdata(dev));
>  }
>  
>  static int error_detected_iter(struct device *device, void *data)
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/