linux-kernel - Re: [PATCH] lenovo-sl-laptop : driver for review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 08:34:19 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Pavel Machek <pavel@....cz>
Cc:	Alexandre Rostovtsev <tetromino@...il.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lenovo-sl-laptop : driver for review

On Tue, 10 Mar 2009, Pavel Machek wrote:
> On Sat 2009-02-28 11:37:11, Henrique de Moraes Holschuh wrote:
> > On Fri, 27 Feb 2009, Pavel Machek wrote:
> > > > +module_param(debug_ec, bool, S_IRUGO);
> > > > +MODULE_PARM_DESC(debug_ec,
> > > > +	"Present EC debugging interface in procfs. WARNING: writing to the "
> > > > +	"EC can hang your system and possibly damage your hardware.");
> > > 
> > > Sounds dangerous and clearly does not belong to /proc. Please drop it.
> > 
> > ThinkPad ACPI also has one.  OTOH, we are fairly sure one cannot damage the
> > standard ThinkPad hardware through the "IBM thinkpad-style" EC firmware, the
> > EC sanity-checks things.  I suppose you could cause the box to go away for
> > lunch and don't come back until a complete hardware reset, or hit one of the
> > crash-the-EC-firmware bugs by accident, though.
> 
> Yeah but that interface still does not belong to /proc. Please drop it
> from merge version at least. 
> 
> > > > +/*************************************************************************
> > > > +    bluetooth sysfs - copied nearly verbatim from thinkpad_acpi.c
> > > > + *************************************************************************/
> > > 
> > > That's quite a lot of code for verbatim copy; create shared helper?
> > 
> > Yeah, I am game.  But let's do it later on and not delay anything because of
> > it, please.  I will start breaking thinkpad-acpi into multiple source files,
> > and after that is done (should take a while, thinkpad-acpi is a big module
> > with a LOT of subdriver interdependencies) we can look for the best way to
> > reduce code duplication.
> 
> Well,  this monolith is quite long/hard to review. IMO it should be
> split to make review easy. 

thinkpad-sl could be split, yes.  But if you guys are going to wait for
thinkpad-acpi to be split _as well_ to do some common-path merging, THAT is
going to take quite a while...

An alternative is to submit a minimal thinkpad-sl, then add features to it
patch-by-patch.  That makes reviewing it easier.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/