linux-kernel - Re: [PATCH] lenovo-sl-laptop : driver for review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 15:12:38 +0100
From:	Pavel Machek <pavel@....cz>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Alexandre Rostovtsev <tetromino@...il.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lenovo-sl-laptop : driver for review

Hi!

> > > > That's quite a lot of code for verbatim copy; create shared helper?
> > > 
> > > Yeah, I am game.  But let's do it later on and not delay anything because of
> > > it, please.  I will start breaking thinkpad-acpi into multiple source files,
> > > and after that is done (should take a while, thinkpad-acpi is a big module
> > > with a LOT of subdriver interdependencies) we can look for the best way to
> > > reduce code duplication.
> > 
> > Well,  this monolith is quite long/hard to review. IMO it should be
> > split to make review easy. 
> 
> thinkpad-sl could be split, yes.  But if you guys are going to wait for
> thinkpad-acpi to be split _as well_ to do some common-path merging, THAT is
> going to take quite a while...

I guess waiting is not neccessary; plus having split thinkpad-sl
driver should make common-path merging easier for you later...

> An alternative is to submit a minimal thinkpad-sl, then add features to it
> patch-by-patch.  That makes reviewing it easier.

Yeah but as we are moving away from mega-driver, anyway, ...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/