linux-kernel - Re: [PATCH] drivers/w1/masters/w1-gpio.c: fix read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090309191419.98699220.akpm@linux-foundation.org>
Date:	Mon, 9 Mar 2009 19:14:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, Ville Syrjala <syrjala@....fi>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	David Brownell <david-b@...bell.net>
Subject: Re: [PATCH] drivers/w1/masters/w1-gpio.c: fix read_bit()

On Mon,  9 Mar 2009 17:02:10 +0100 Daniel Mack <daniel@...aq.de> wrote:

> W1 master implementations are expected to return 0 or 1 from their
> read_bit() function. However, not all platforms do return these values
> from gpio_get_value() - namely PXAs won't. Hence the w1 gpio-master
> needs to break the result down to 0 or 1 itself.
> 
> Signed-off-by: Daniel Mack <daniel@...aq.de>
> Cc: Ville Syrjala <syrjala@....fi>
> Cc: Evgeniy Polyakov <johnpol@....mipt.ru>
> ---
>  drivers/w1/masters/w1-gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
> index 9e1138a..a411702 100644
> --- a/drivers/w1/masters/w1-gpio.c
> +++ b/drivers/w1/masters/w1-gpio.c
> @@ -39,7 +39,7 @@ static u8 w1_gpio_read_bit(void *data)
>  {
>  	struct w1_gpio_platform_data *pdata = data;
>  
> -	return gpio_get_value(pdata->pin);
> +	return gpio_get_value(pdata->pin) ? 1 : 0;
>  }
>  
>  static int __init w1_gpio_probe(struct platform_device *pdev)

We recently merged a patch (I forget where) which fixed one
gpio_get_value() implementation so that it always returns 0 or 1.

>From which I deduce that the correct fix for <whatever problem you're
seeing> is to fix <whichever driver that is>?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/