linux-kernel - Re: [patch 04/11] Introduce virtual debug register in thread_struct and wrapper-routines around process related functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0903101151450.3979-100000@iolanthe.rowland.org>
Date:	Tue, 10 Mar 2009 11:53:41 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ingo Molnar <mingo@...e.hu>
cc:	prasad@...ux.vnet.ibm.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Roland McGrath <roland@...hat.com>
Subject: Re: [patch 04/11] Introduce virtual debug register in thread_struct
 and wrapper-routines around process related functions

On Tue, 10 Mar 2009, Ingo Molnar wrote:

> and why is this:
> 
> > @@ -427,13 +427,9 @@ struct thread_struct {
> >  	unsigned long		ip;
> >  	unsigned long		fs;
> >  	unsigned long		gs;
> > -	/* Hardware debugging registers: */
> > -	unsigned long		debugreg0;
> > -	unsigned long		debugreg1;
> > -	unsigned long		debugreg2;
> > -	unsigned long		debugreg3;
> > -	unsigned long		debugreg6;
> > -	unsigned long		debugreg7;
> > +	/* Hardware breakpoint info */
> > +	unsigned long	vdr6;
> > +	struct thread_hw_breakpoint	*hw_breakpoint_info;
> 
> detached from thread_struct? There's a lot of complications 
> (alloc/free, locking, etc.) from this for no good reason - the 
> hardware-breakpoints info structure is alway per thread and is 
> quite small, so there's no reason not to embedd it directly 
> inside thread_struct.

The only reason for separating it out was to avoid bogging down the 
vast majority of threads which aren't debugged.  If you think the extra 
overhead isn't worth worrying about then the hw-breakpoint info 
structure can be embedded.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/