linux-kernel - [PATCH] powerpc 4xx EMAC driver: device name reported on timeout is not correct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B6B240.8030701@lebon.org.ua>
Date:	Tue, 10 Mar 2009 20:32:32 +0200
From:	Mikhail Zolotaryov <lebon@...on.org.ua>
To:	linux-kernel@...r.kernel.org
CC:	linuxppc-dev@...abs.org, Josh Boyer <jwboyer@...ux.vnet.ibm.com>
Subject: [PATCH] powerpc 4xx EMAC driver: device name reported on timeout
 is not correct

Hi,

not critical problem here.

IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c: 
emac_probe() -> emac_init_phy() -> emac_reset()) before registering 
appropriate net_device (emac_probe() -> register_netdev()), so 
net_device name contains raw format string during EMAC reset ("eth%d").

If the case of reset timeout, emac_report_timeout_error() function is 
called to report an error. The problem is this function uses net_device 
name to report device related, which is not correct, as a result in the 
kernel log buffer we see:

eth%d: reset timeout

The solution is to print device_node full_name instead. After applying 
the patch proposed, error string is like the following:

/plb/opb/ethernet@...00e00: reset timeout

Signed-off-by: Mikhail Zolotaryov <lebon@...on.org.ua>

View attachment "emac_report_timeout_error.patch" of type "text/plain" (441 bytes)