linux-kernel - Re: [PATCH 26/31] usb: Auto-load cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 19:34:05 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Scott James Remnant <scott@...onical.com>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 26/31] usb: Auto-load cdc_acm module when device opened.

On Tue, Mar 10, 2009 at 18:18, Scott James Remnant <scott@...onical.com> wrote:
> On Tue, 2009-03-10 at 10:08 -0700, Greg KH wrote:
>> On Mon, Mar 02, 2009 at 06:46:15PM +0000, Scott James Remnant wrote:
>> > The cdc_acm module is missing the char-major-166-* alias that would
>> > cause it to be auto-loaded when a device of that type is opened.  This
>> > patch adds the alias.
>>
>> You really have users that are using a static /dev that need this kind
>> of fix?  I thought we were phasing out the char-major- aliases as they
>> don't make any sense anymore.
>>
> I don't think so.
>
> But since we had aliases to support users, I wasn't going to drop them
> without at least sending a patch upstream to see if they cared about
> such things.
>
> (and there are many modules which do have the char-major aliases, so at
> least someone is trying to put them in).
>
> As noted in the cover, feel free to drop these - I can use your reply
> when a user complains <g>

Yeah, we should put them into the module, where they belong, or just
remove them all. :) They surely do not belong into disconnected
userspace config files.

We are going to delete all kernel module configurations from the
userspace packages, and the only alternative for the kernel to provide
the autoload-by-open facility to users who like to use that, would be
that the kernel installs a modprobe config file which is maintained by
the kernel maintainers. Not sure if someone wants to do that instead.
:)

The new modprobe does not really care how many aliases we have, the
time to lookup the aliases depends mainly on the length of the alias
lookup string, not the number of strings to match against, so this
should all be fine.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/