linux-kernel - Re: checkpatch and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090310183610.GE28243@shadowen.org>
Date:	Tue, 10 Mar 2009 18:36:10 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc:	Joel Schopp <jschopp@...tin.ibm.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch and pr_fmt()?

On Thu, Dec 18, 2008 at 05:24:06PM +0100, Geert Uytterhoeven wrote:
> When using the recently introduced pr_fmt() infrastructure (commit
> d091c2f58ba32029495a933b721e8e02fbd12caa, "Add 'pr_fmt()' format modifier to
> pr_xyz macros."), checkpatch spits out the following annoying error:
> 
> | ERROR: Macros with complex values should be enclosed in parenthesis
> | +#define pr_fmt(fmt)    "%s: " fmt, __func__
> 
> Unfortunately, adding parentheses is not a solution, as it creates illegal C
> code.

Yeah that one looks like something we should avoid.  Fixed in my next
update which can be tested here:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/