linux-kernel - RE: [PATCH 03/25] [net] BUG to BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A1E7589DC@orsmsx507.amr.corp.intel.com>
Date:	Tue, 10 Mar 2009 12:54:33 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Stoyan Gaydarov <stoyboyker@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 03/25] [net] BUG to BUG_ON changes

Stoyan Gaydarov wrote:
> Signed-off-by: Stoyan Gaydarov <stoyboyker@...il.com>
> ---
>  drivers/net/atl1e/atl1e_main.c    |    3 +--
>  drivers/net/chelsio/sge.c         |    3 +--
>  drivers/net/ixgb/ixgb_osdep.h     |    2 +-
>  drivers/net/pppol2tp.c            |    3 +--
>  drivers/net/wireless/ath9k/core.h |    6 +-----
>  5 files changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/ixgb/ixgb_osdep.h
> b/drivers/net/ixgb/ixgb_osdep.h 
> index d92e72b..371a6be 100644
> --- a/drivers/net/ixgb/ixgb_osdep.h
> +++ b/drivers/net/ixgb/ixgb_osdep.h
> @@ -40,7 +40,7 @@
>  #include <linux/sched.h>
> 
>  #undef ASSERT
> -#define ASSERT(x)	if (!(x)) BUG()
> +#define ASSERT(x)	BUG_ON(!(x))
>  #define MSGOUT(S, A, B)	printk(KERN_DEBUG S "\n", A, B)
> 
>  #ifdef DBG

ack the ixgb portion

Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/