linux-kernel - Re: [PATCH] tweak spin logic for hpilo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B6F9A9.1030803@gmail.com>
Date:	Tue, 10 Mar 2009 17:37:13 -0600
From:	Robert Hancock <hancockrwd@...il.com>
To:	"Altobelli, David" <david.altobelli@...com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tweak spin logic for hpilo

Altobelli, David wrote:
>> From: Andrew Morton
>> David Altobelli wrote:
>>> Change hpilo open and close logic to spin for 10usec between checking
>>> device, rather than every usec.
>> err.. Why?
> 
> Because the loop is coded to take up to 10ms, it seemed prudent to increase
> the interval between polling the device, to reduce the load on the system and
> allow more other work to happen.

You're using udelay, which is a spin loop. Nothing else can happen on 
that CPU while it's delaying anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/