linux-kernel - Re: linux-next: Tree for March 11 (staging/multimedia)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903111927.51015.hverkuil@xs4all.nl>
Date:	Wed, 11 Mar 2009 19:27:50 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Greg KH <gregkh@...e.de>, Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-media@...r.kernel.org
Subject: Re: linux-next: Tree for March 11 (staging/multimedia)

On Wednesday 11 March 2009 19:21:52 Randy Dunlap wrote:
> Greg KH wrote:
> > On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote:
> >> Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20090310:
> >>
> >> drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE'
> >> undeclared here (not in a function)
> >
> > Odd, nothing has changed in this driver, is this a v4l api change?
>
> I don't know if the vl4 API changed, but this error has been around
> for some time now.  Just because it's just now being reported is one
> change.  Surely other people build these drivers.  ???
>
>
> I do know that other video drivers (with one exception) don't set:
> 	.vfl_type	= VID_TYPE_CAPTURE,
> at all, so maybe it's not needed (?).

That's correct, this assignment isn't needed. The error appears now since 
VID_TYPE_CAPTURE has been made inaccessible for V4L2 drivers. Only old V4L1 
drivers can use it.

This change was very recent and before that it compiled fine. Although even 
then that code was wrong (but harmless).

Just remove that line and it will compile fine again. Although unless 
someone will take this driver to the next level it will probably break 
again once the old autoprobing i2c API is removed (and that's slated for 
2.6.30 if all goes well).

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/