linux-kernel - Re: [PATCH 1/2] x86: unify kmap_atomic_pfn() and iomap_atomic_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <961aa3350903111728m6203106tf74a767f1a82e663@mail.gmail.com>
Date:	Thu, 12 Mar 2009 09:28:09 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 1/2] x86: unify kmap_atomic_pfn() and iomap_atomic_prot_pfn()

2009/3/12 Ingo Molnar <mingo@...e.hu>:
>
> * Akinobu Mita <akinobu.mita@...il.com> wrote:
>
>> 2009/3/12 Thomas Gleixner <tglx@...utronix.de>:
>> > On Wed, 11 Mar 2009, Akinobu Mita wrote:
>> >> kmap_atomic_pfn() and iomap_atomic_prot_pfn() are almost same except
>> >> pgprot. This patch removes the code duplication for these two functions.
>> >
>> > How exaclty does this compile with CONFIG_HIGHMEM=n ?
>> >
>>
>> Oh, I didn't try without CONFIG_HIGHMEM.
>
> i had it applied in testing locally and didnt see problems so
> far. Let me know if you can see any problems.

It actually didn't compile with CONFIG_HIGHMEM=n as Thomas pointed out.

arch/x86/mm/iomap_32.c:49: undefined reference to `kmap_atomic_prot_pfn'

So please revert 1/2 and 2/2. However, I still think 2/2 is usefull and
I'll submit it in other form.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/