linux-kernel - [tip:x86/uv] x86, uv: fix cpumask iterator in uv_bau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-2c74d66624ddbda8101d54d1e184cf9229b378bc@git.kernel.org>
Date:	Wed, 18 Mar 2009 08:51:43 GMT
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	travis@....com, rusty@...tcorp.com.au, cpw@....com,
	stable@...nel.org, tglx@...utronix.de, mingo@...e.hu
Subject: [tip:x86/uv] x86, uv: fix cpumask iterator in uv_bau_init()

Commit-ID:  2c74d66624ddbda8101d54d1e184cf9229b378bc
Gitweb:     http://git.kernel.org/tip/2c74d66624ddbda8101d54d1e184cf9229b378bc
Author:     Rusty Russell <rusty@...tcorp.com.au>
AuthorDate: Wed, 18 Mar 2009 08:22:30 +1030
Commit:     Ingo Molnar <mingo@...e.hu>
CommitDate: Wed, 18 Mar 2009 09:47:54 +0100

x86, uv: fix cpumask iterator in uv_bau_init()

Impact: fix boot crash on UV systems

Commit 76ba0ecda0de9accea9a91cb6dbde46782110e1c "cpumask: use
cpumask_var_t in uv_flush_tlb_others" used cur_cpu as an iterator;
it was supposed to be zero for the code below it.

Reported-by: Cliff Wickman <cpw@....com>
Original-From: Cliff Wickman <cpw@....com>
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
Acked-by: Mike Travis <travis@....com>
Cc: steiner@....com
Cc: <stable@...nel.org>
LKML-Reference: <200903180822.31196.rusty@...tcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 arch/x86/kernel/tlb_uv.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/tlb_uv.c b/arch/x86/kernel/tlb_uv.c
index d038b9c..79c0732 100644
--- a/arch/x86/kernel/tlb_uv.c
+++ b/arch/x86/kernel/tlb_uv.c
@@ -750,7 +750,7 @@ static int __init uv_bau_init(void)
 	int node;
 	int nblades;
 	int last_blade;
-	int cur_cpu = 0;
+	int cur_cpu;
 
 	if (!is_uv_system())
 		return 0;
@@ -760,6 +760,7 @@ static int __init uv_bau_init(void)
 	uv_mmask = (1UL << uv_hub_info->n_val) - 1;
 	nblades = 0;
 	last_blade = -1;
+	cur_cpu = 0;
 	for_each_online_node(node) {
 		blade = uv_node_to_blade_id(node);
 		if (blade == last_blade)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/