linux-kernel - Re: [PATCH] tracing/ftrace: stop {irqs,preempt}soff tracers when tracing is stopped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090318092929.GA8475@elte.hu>
Date:	Wed, 18 Mar 2009 10:29:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/ftrace: stop {irqs,preempt}soff tracers when
	tracing is stopped


* Ingo Molnar <mingo@...e.hu> wrote:

> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > > I discussed about that with Steven on irc, and for now the v1 
> > > should be applied as a temporary solution. We plan to simplify 
> > > later the start/stop callbacks from each tracers that need it.
> > 
> > ok. Steve, could you please pick v1 up?
> 
> Committed it after all - there's more self-test failures (reported 
> them earlier today) and i've picked up all fixlets that might fix 
> them.

it's still happening even with all fixes applied, on latest -tip:

[    3.132006] calling  init_irqsoff_tracer+0x0/0x11 @ 1
[    3.137005] Testing tracer irqsoff: <4>------------[ cut here ]------------
[    3.141002] WARNING: at kernel/trace/trace.c:466 update_max_tr_single+0xaf/0x140()
[    3.141002] Hardware name: System Product Name
[    3.141002] Modules linked in:
[    3.141002] Pid: 1, comm: swapper Not tainted 2.6.29-rc8-tip-02702-ge0d2c41-dirty #20985
[    3.141002] Call Trace:
[    3.141002]  [<c10488c6>] warn_slowpath+0x76/0xb0
[    3.141002]  [<c147dda1>] ? _spin_lock_irq+0x11/0x30
[    3.141002]  [<c1050304>] ? run_timer_softirq+0x174/0x180
[    3.141002]  [<c104d01b>] ? _local_bh_enable+0x8b/0xa0
[    3.141002]  [<c104d1a2>] ? __do_softirq+0x172/0x180
[    3.141002]  [<c1074444>] ? ring_buffer_reset_cpu+0x24/0xe0
[    3.141002]  [<c10744ed>] ? ring_buffer_reset_cpu+0xcd/0xe0
[    3.141002]  [<c147dcb9>] ? _spin_unlock_irqrestore+0x19/0x30
[    3.141002]  [<c107c721>] ? trace_hardirqs_off+0x21/0x30
[    3.141002]  [<c147dcb9>] ? _spin_unlock_irqrestore+0x19/0x30
[    3.141002]  [<c10744ed>] ? ring_buffer_reset_cpu+0xcd/0xe0
[    3.141002]  [<c107990f>] update_max_tr_single+0xaf/0x140
[    3.141002]  [<c107c8bc>] stop_critical_timing+0x15c/0x210
[    3.141002]  [<c1079f8d>] ? register_tracer+0x10d/0x200
[    3.141002]  [<c107c9b1>] trace_hardirqs_on+0x21/0x30
[    3.141002]  [<c107a263>] trace_selftest_startup_irqsoff+0x53/0xb0
[    3.141002]  [<c16fb8a2>] ? init_irqsoff_tracer+0x0/0x11
[    3.141002]  [<c1079f8d>] register_tracer+0x10d/0x200
[    3.141002]  [<c16fb8a2>] ? init_irqsoff_tracer+0x0/0x11
[    3.141002]  [<c16fb8af>] init_irqsoff_tracer+0xd/0x11
[    3.141002]  [<c100107a>] do_one_initcall+0x6a/0x170
[    3.141002]  [<c1090d63>] ? zone_statistics+0x63/0x70
[    3.141002]  [<c10886a6>] ? __alloc_pages_internal+0xa6/0x390
[    3.141002]  [<c11a58aa>] ? put_dec+0x2a/0x100
[    3.141002]  [<c10a1a14>] ? check_valid_pointer+0x24/0x60
[    3.141002]  [<c10a2041>] ? check_object+0x131/0x170
[    3.141002]  [<c10a28a4>] ? __slab_free+0x274/0x2a0
[    3.141002]  [<c11a1557>] ? ida_get_new_above+0x157/0x180
[    3.141002]  [<c11a1557>] ? ida_get_new_above+0x157/0x180
[    3.141002]  [<c10a428f>] ? kmem_cache_free+0x8f/0xa0
[    3.141002]  [<c11a1557>] ? ida_get_new_above+0x157/0x180
[    3.141002]  [<c11a1557>] ? ida_get_new_above+0x157/0x180
[    3.141002]  [<c11a197f>] ? idr_pre_get+0x4f/0x60
[    3.141002]  [<c10e0d43>] ? proc_register+0x103/0x150
[    3.141002]  [<c10e0ec0>] ? create_proc_entry+0x80/0xa0
[    3.141002]  [<c106e278>] ? init_irq_proc+0x58/0x70
[    3.141002]  [<c16e95db>] kernel_init+0x104/0x155
[    3.141002]  [<c16e94d7>] ? kernel_init+0x0/0x155
[    3.141002]  [<c101f8e3>] kernel_thread_helper+0x7/0x10
[    3.141002] ---[ end trace 5a5d197966b56a2e ]---
[    3.376012] .. no entries found ..FAILED!
[    3.380006] initcall init_irqsoff_tracer+0x0/0x11 returned 0 after 237304 usecs
[    3.388006] calling  init_wakeup_tracer+0x0/0x1d @ 1

Config and log attached.

	Ingo

View attachment "config" of type "text/plain" (58132 bytes)

View attachment "log" of type "text/plain" (124666 bytes)