linux-kernel - [PATCH] kobject: don't block for each kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090319090905.609d3750@infradead.org>
Date:	Thu, 19 Mar 2009 09:09:05 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	linux-kernel@...r.kernel.org
Cc:	gregkh@...e.de, akpm@...ux-foundation.org
Subject: [PATCH] kobject: don't block for each kobject_uevent

>From d44701ae98a2c43a898dd7a7765d8894fd2e6caa Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@...ux.intel.com>
Date: Thu, 19 Mar 2009 09:02:17 -0700
Subject: [PATCH] kobject: don't block for each kobject_uevent

Right now, the kobject_uevent code blocks for each uevent that's being generated,
due to using (for hystoric reasons) UHM_WAIT_EXEC as flag to call_usermode_helper().
Specifically, the effect is that each uevent that is being sent causes the code to
wake up keventd, then block until keventd has processed the work. Needless to say,
this happens many times during the system boot.

This patches changes that to UHN_NO_WAIT (brilliant name for a constant btw) so
that we only schedule the work to fire the uevent message, but do not wait for
keventd to process the work.

This removes one of the bottlenecks during boot; each one of them is only a small
effect, but the sum of them does add up.

Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
---
 lib/kobject_uevent.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 318328d..0b63523 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -248,7 +248,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
 			goto exit;

 		retval = call_usermodehelper(argv[0], argv,
-					     env->envp, UMH_WAIT_EXEC);
+					     env->envp, UMH_NO_WAIT);
 	}

 exit:
-- 
1.6.0.6

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/