[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1237486140.6781.340.camel@vega.slimlogic.co.uk>
Date: Thu, 19 Mar 2009 18:09:00 +0000
From: Liam Girdwood <lrg@...mlogic.co.uk>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: Don't increment use_count for boot_on
regulators
On Mon, 2009-03-16 at 19:36 +0000, Mark Brown wrote:
> Don't set use_count for regulators that are enabled at boot since this
> stops the supply being disabled by well-behaved consumers which do
> balanced enables and disabled. Any consumers which don't do disables
> which are not matched by enables are unable to share regulators - shared
> regulators are the common case so the API should facilitate them.
>
> Consumers that want to disable regulators that are enabled when they
> start have two options:
>
> - Do a regulator_enable() prior to the disable to bring the use count
> in sync with the hardware state; this will ensure that if the
> regulator was enabled by another driver then this consumer will play
> nicely with it.
> - Use regulator_force_disable(); this explicitly bypasses any checks
> done by the core and documents the inability of the driver to share
> the supply.
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
> drivers/regulator/core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Applied.
Thanks
Liam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists