linux-kernel - Re: [PATCH v4 06/12] PCI: Introduce pci_rescan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090319180912.GB14127@parisc-linux.org>
Date:	Thu, 19 Mar 2009 12:09:12 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Alex Chiang <achiang@...com>
Cc:	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	jbarnes@...tuousgeek.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/12] PCI: Introduce pci_rescan_bus()

On Thu, Mar 19, 2009 at 11:49:38AM -0600, Alex Chiang wrote:
> I went over and ran it on all my patches, and that was indeed one
> of the complaints.
> 
> But when it comes to file consistency vs "letter of the law" I
> like to keep things consistent (even if broken) in the file.
> 
> I could go back and move all those EXPORT_SYMBOL declarations to
> the "proper" place. Is that too much noise though?

The accepted way to do this is to add a prep patch which just fixes the
checkpatch warnings (ie moves the EXPORT_SYMBOLs).  Then your patch is
all shiny and fresh.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/