linux-kernel - RE: [patch] x86, bts: use atomic memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77E924000A9@irsmsx504.ger.corp.intel.com>
Date:	Fri, 20 Mar 2009 16:23:44 +0000
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"eranian@...glemail.com" <eranian@...glemail.com>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"Villacis, Juan" <juan.villacis@...el.com>,
	"ak@...ux.jf.intel.com" <ak@...ux.jf.intel.com>
Subject: RE: [patch] x86, bts: use atomic memory allocation

>-----Original Message-----
>From: Metzger, Markus T
>Sent: Friday, March 20, 2009 9:08 AM
>To: Ingo Molnar


>>> Ds_request_bts() needs to allocate memory. It uses GFP_KERNEL.
>>>
>>> Hw-branch-tracer calls ds_request_bts() within on_each_cpu().
>>>
>>> Use atomic memory allocation to allow it to be used in that context.
>>
>>the hw-branch-tracer still crashes during bootup. Have you tried the
>>config i sent to you, and have you tried to reproduce it? I've
>>attached another config that crashes.
>
>The first config boots OK.
>The second config boots OK with the additional changes to keep the GFP_KERNEL
>and move the ds_request_bts() calls out of the on_each_cpu() in the hw-branch-tracer.

I must have been asleep this morning.
The first config boots OK.
The second config does not boot, at all. Even if I completely disable DS support in the config.
However, with the new patches, it boots as far as with DS disabled.
It then hangs after CFA self-test.

With DS enabled and without the patches, it stops with a call trace somewhere in
the hw-branch-tracer selftest.


>I then bootet a defconfig kernel with some debugging enabled and I get the following
>message:
>[    1.731080] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
>[    1.731180] swapper/0 [HC1[1]:SC0[0]:HE0:SE1] takes:
>[    1.731180]  (ds_lock){?.+...}, at: [<ffffffff8101560f>] ds_put_context+0x21/0xf3

I fixed this, as well, meanwhile.


regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/