linux-kernel - Re: [patch] x86, bts: use atomic memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2009 19:55:59 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Metzger, Markus T" <markus.t.metzger@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"eranian@...glemail.com" <eranian@...glemail.com>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"Villacis, Juan" <juan.villacis@...el.com>,
	"ak@...ux.jf.intel.com" <ak@...ux.jf.intel.com>
Subject: Re: [patch] x86, bts: use atomic memory allocation


* Metzger, Markus T <markus.t.metzger@...el.com> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@...e.hu]
> >Sent: Thursday, March 19, 2009 5:12 PM
> >To: Metzger, Markus T
> 
> 
> >> Ds_request_bts() needs to allocate memory. It uses GFP_KERNEL.
> >>
> >> Hw-branch-tracer calls ds_request_bts() within on_each_cpu().
> >>
> >> Use atomic memory allocation to allow it to be used in that context.
> >
> >the hw-branch-tracer still crashes during bootup. Have you tried the
> >config i sent to you, and have you tried to reproduce it? I've
> >attached another config that crashes.
> 
> The first config boots OK.

> The second config boots OK with the additional changes to keep the 
> GFP_KERNEL and move the ds_request_bts() calls out of the 
> on_each_cpu() in the hw-branch-tracer.
> 
> I don't know yet what exactly causes the crash and if there is a 
> simpler fix.

hm, this was an AMD box - so perhaps they dont have a compatible DS 
implementation?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/