[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <12135.1237805607@redhat.com>
Date: Mon, 23 Mar 2009 10:53:27 +0000
From: David Howells <dhowells@...hat.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Nick Piggin <npiggin@...e.de>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Rik van Riel <riel@...hat.com>,
Peter Zijlstra <peterz@...radead.com>,
MinChan Kim <minchan.kim@...il.com>,
Lee Schermerhorn <Lee.Schermerhorn@...com>
Subject: Re: [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists
Johannes Weiner <hannes@...xchg.org> wrote:
> - if (page_is_file_cache(page))
> + if (mapping_unevictable(mapping))
> + add_page_to_unevictable_list(page);
> + else if (page_is_file_cache(page))
It would be nice to avoid adding an extra test and branch in here. This
function is used a lot, and quite often we know the answer to the first test
before we even get here.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists