linux-kernel - Re: [git-pull -tip] x86: cleanup patches 20090322

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903231845.05394.rusty@rustcorp.com.au>
Date:	Mon, 23 Mar 2009 18:45:04 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Yinghai Lu <yinghai@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git-pull -tip] x86: cleanup patches 20090322

On Monday 23 March 2009 07:22:56 Jaswinder Singh Rajput wrote:
>       x86: e820.h fix various signedness issues in setup.c and e820.c

Wouldn't fixing the users be better than changing the header?  Esp. since
it could well now cause similar warnings in userspace programs.

>  struct e820map {
> -	__u32 nr_map;
> +	__s32 nr_map;
>  	struct e820entry map[E820_X_MAX];
>  };

This number can't be negative!

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/