[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090323.011508.140910146.davem@davemloft.net>
Date: Mon, 23 Mar 2009 01:15:08 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jarkao2@...il.com
Cc: mpm@...enic.com, marcin.slusarz@...il.com, netdev@...r.kernel.org,
k-keiichi@...jp.nec.com, stable@...nel.org, rjw@...k.pl,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netconsole: fix BUG during net device "upping"
From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 23 Mar 2009 08:11:58 +0000
> On Mon, Mar 23, 2009 at 01:05:41AM -0700, David Miller wrote:
> > From: Jarek Poplawski <jarkao2@...il.com>
> > Date: Mon, 23 Mar 2009 08:04:55 +0000
> >
> > > What is the rationale of this decision? printk is a basic tool,
> > > especially designed to work in as many places as possible, and
> > > netconsole is rather something secondary (sorry Matt)?!
> >
> > And this basic tool cannot work from the drivers ->open() method.
>
> And in any function used in the drivers ->open(). BTW, with Marcin's
> patch it can...
This issue came up before, and after we added the netif_running()
check we hit this IIF_UP one and at the time we looked into it
and the result we came up with is that you just can't do it in
a network driver's ->open()
Look up the thread, I'm too lazy...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists