[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090324112443.GI27476@kernel.dk>
Date: Tue, 24 Mar 2009 12:24:43 +0100
From: Jens Axboe <jens.axboe@...cle.com>
To: Nikanth Karthikesan <knikanth@...e.de>
Cc: Christoph Hellwig <hch@...radead.org>,
Gerd Hoffmann <kraxel@...hat.com>,
Constantine Sapuntzakis <csapuntz@...il.com>,
Miklos Szeredi <miklos@...redi.hu>, nikanth@...il.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Block - Honour barrier requests in loop driver
On Tue, Mar 24 2009, Nikanth Karthikesan wrote:
> On Wednesday 18 March 2009 10:28:20 Nikanth Karthikesan wrote:
> > On Wednesday 18 March 2009 00:39:05 Christoph Hellwig wrote:
> > > On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote:
> > > > + if (!file->f_op || !file->f_op->fsync) {
> > > > + ret = -EOPNOTSUPP;
> > > > + goto out;
> > > > + }
> > >
> > > file->f_op is never zero, so you can remove the checks for that.
> > > Otherwise looks good.
> >
> > Thanks for reviewing. I've removed that check.
> >
> > Jens, Can you merge this?
> >
> Hi Jens
>
> Did you get to look at this? Can you merge this?
Yep, I'll merge it. Thanks!
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists