linux-kernel - Re: [PATCH] Block - Honour barrier requests in loop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090324112652.GJ27476@kernel.dk>
Date:	Tue, 24 Mar 2009 12:26:53 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Nikanth Karthikesan <knikanth@...e.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Gerd Hoffmann <kraxel@...hat.com>,
	Constantine Sapuntzakis <csapuntz@...il.com>,
	Miklos Szeredi <miklos@...redi.hu>, nikanth@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Block - Honour barrier requests in loop driver

On Tue, Mar 24 2009, Jens Axboe wrote:
> On Tue, Mar 24 2009, Nikanth Karthikesan wrote:
> > On Wednesday 18 March 2009 10:28:20 Nikanth Karthikesan wrote:
> > > On Wednesday 18 March 2009 00:39:05 Christoph Hellwig wrote:
> > > > On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote:
> > > > > +			if (!file->f_op || !file->f_op->fsync) {
> > > > > +				ret = -EOPNOTSUPP;
> > > > > +				goto out;
> > > > > +			}
> > > >
> > > > file->f_op is never zero, so you can remove the checks for that.
> > > > Otherwise looks good.
> > >
> > > Thanks for reviewing. I've removed that check.
> > >
> > > Jens, Can you merge this?
> > >
> > Hi Jens
> > 
> > Did you get to look at this? Can you merge this?
> 
> Yep, I'll merge it. Thanks!

Patch is line wrapped, and you still have one more check for f->f_op ==
NULL that you don't need. I have fixed it up, but please fix your
mailer.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/