[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090325081151.GD27002@infomag.iguana.be>
Date: Wed, 25 Mar 2009 09:11:51 +0100
From: Wim Van Sebroeck <wim@...ana.be>
To: stoyboyker@...il.com
Cc: linux-kernel@...r.kernel.org, wim@...ana.be
Subject: Re: [PATCH 08/13] [watchdog] changed ioctls to unlocked
Hi Stoyan,
> From: Stoyan Gaydarov <stoyboyker@...il.com>
>
> Signed-off-by: Stoyan Gaydarov <stoyboyker@...il.com>
> ---
> drivers/watchdog/riowd.c | 37 +++++++++++++++++++++++++++----------
> 1 files changed, 27 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/watchdog/riowd.c b/drivers/watchdog/riowd.c
> index 09cb183..44058c1 100644
> --- a/drivers/watchdog/riowd.c
> +++ b/drivers/watchdog/riowd.c
> @@ -86,9 +86,10 @@ static int riowd_release(struct inode *inode, struct file *filp)
> return 0;
> }
>
> -static int riowd_ioctl(struct inode *inode, struct file *filp,
> - unsigned int cmd, unsigned long arg)
> +static long riowd_ioctl(struct file *filp, unsigned int cmd,
> + unsigned long arg)
> {
> + lock_kernel();
NAK. See commit c2dc3084010a7996c34e84bea14ff5346af7abd7 in the linux-2.6-watchdog-next tree that allready fixes this (and that will go to Linus one of these days for inclusion).
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists