linux-kernel - RE: [PATCH 2/5] mm: remove unlikly NULL from kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1237968394.30175.12.camel@penberg-laptop>
Date:	Wed, 25 Mar 2009 10:06:34 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Hua Zhong <hzhong@...il.com>
Cc:	'Steven Rostedt' <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org, 'Ingo Molnar' <mingo@...e.hu>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Thomas Gleixner' <tglx@...utronix.de>,
	'Peter Zijlstra' <peterz@...radead.org>,
	'Roland McGrath' <roland@...hat.com>,
	'Nick Piggin' <nickpiggin@...oo.com.au>,
	'Steven Rostedt' <srostedt@...hat.com>,
	'Christoph Lameter' <cl@...ux-foundation.org>,
	'Matt Mackall' <mpm@...enic.com>
Subject: RE: [PATCH 2/5] mm: remove unlikly NULL from kfree

On Wed, 2009-03-25 at 01:02 -0700, Hua Zhong wrote:
> > But those are _error handling paths_ (at least supposed to be). I
> > wonder which call-sites are responsible for this. Can frtrace help us
> > here?
> 
> I am not sure why you call these error paths.
> 
> I submitted the same patch two years ago, and you are still holding the same
> argument.
> 
> http://www.archivum.info/linux.kernel/2006-04/msg06042.html
> 
> Have you used likely profiler? These are real numbers. If you insist on
> calling them error paths then error paths are obviously the norm.

I am not denying the results, I am just saying that they don't make much
sense to me. Like I said, I would love to see the actual call-sites to
prove my argument wrong.

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/