linux-kernel - Re: [PATCH 1/5] ptrace: remove incorrect unlikelys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090325092818.8742CFC336@magilla.sf.frob.com>
Date:	Wed, 25 Mar 2009 02:28:18 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/5] ptrace: remove incorrect unlikelys

This is mislabeled, really.  This is "x86: syscall-audit", not ptrace.

I think this one also warrants moving the if inside a generic (non-arch)
inline.  The choice about unlikely() is not arch-specific, nor (AFIAK) is
the logic of the if.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/