linux-kernel - Re: [PATCH] x86: don't compile vsmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325232921.GL7278@localdomain>
Date:	Wed, 25 Mar 2009 16:29:21 -0700
From:	Ravikiran G Thirumalai <kiran@...lex86.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	shai@...lex86.org
Subject: Re: [PATCH] x86: don't compile vsmp_64 for 32bit

On Wed, Mar 25, 2009 at 04:15:49PM -0700, Jeremy Fitzhardinge wrote:
> Ravikiran G Thirumalai wrote:
>> On Wed, Mar 25, 2009 at 03:16:14PM -0700, Jeremy Fitzhardinge wrote:
>>   
>>> Ravikiran G Thirumalai wrote:
>>>     
>>>> It is already there, and has been there!  But we still need to make
>>>> vsmp64.c compile only when CONFIG_X86_64 is defined no?
>>>>         
>>> I still think you should restructure it so that vsmp_64.c only gets 
>>> compiled with CONFIG_X86_VSMP enabled.  Having all that stuff compiled 
>>> into every kernel seems pretty pointless.
>>>
>>>     
>>
>> Well, not everything gets compiled in.  Only the is_vsmp_box() logic and
>> related stuff gets compiled in.  Other paravirt related stuff in vsmp64.c
>> depends on CONFIG_PARAVIRT.
>>   
>
> Sure, but it would be cleaner if the whole file were controlled by 
> CONFIG_X86_VSMP.  is_vsmp_box() is already defined as const inline 
> returning 0 if !CONFIG_X86_VSMP.
>

The point in this thread was, is_vsmp_box() needs to be meaningful even when
CONFIG_X86_VSMP is not on.  This is needed because is_vsmp_box() is used to
determine if the platform has reliable tscs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/