linux-kernel - Re: USB: serial: add symbol serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090326194228.52087a47@lxorguk.ukuu.org.uk>
Date:	Thu, 26 Mar 2009 19:42:28 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	torvalds@...ux-foundation.org, greg@...ah.com
Subject: Re: USB: serial: add symbol serial driver

On Thu, 26 Mar 2009 19:29:28 GMT
Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:

Thank you for not running this past the tty layer maintainer.


> +	/*
> +	 * Force low_latency on so that our tty_push actually forces the data
> +	 * through, otherwise it is scheduled, and with high data rates (like
> +	 * with OHCI) data can get lost.
> +	 */
> +	if (tty)
> +		tty->low_latency = 1;

The above is bogus cargo cult programming copied from old drivers and
should be removed.



Otherwise looks fine
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/