linux-kernel - Re: USB: serial: add symbol serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090406053753.GA12019@kroah.com>
Date:	Sun, 5 Apr 2009 22:37:53 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	torvalds@...ux-foundation.org
Subject: Re: USB: serial: add symbol serial driver

On Thu, Mar 26, 2009 at 07:42:28PM +0000, Alan Cox wrote:
> On Thu, 26 Mar 2009 19:29:28 GMT
> Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:
> 
> Thank you for not running this past the tty layer maintainer.

Sorry about that.

> > +	/*
> > +	 * Force low_latency on so that our tty_push actually forces the data
> > +	 * through, otherwise it is scheduled, and with high data rates (like
> > +	 * with OHCI) data can get lost.
> > +	 */
> > +	if (tty)
> > +		tty->low_latency = 1;
> 
> The above is bogus cargo cult programming copied from old drivers and
> should be removed.

It's all over the usb-serial drivers, should I just remove it from all
of them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/