linux-kernel - Re: TOMOYO in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090327113553.GB2585@elf.ucw.cz>
Date:	Fri, 27 Mar 2009 12:35:53 +0100
From:	Pavel Machek <pavel@....cz>
To:	James Morris <jmorris@...ei.org>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	linux-security-module@...r.kernel.org, Greg KH <greg@...ah.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: TOMOYO in linux-next

On Fri 2009-03-27 11:46:42, James Morris wrote:
> On Fri, 27 Mar 2009, Pavel Machek wrote:
> 
> > Hi!
> > 
> > > As for the rest of the feedback, please work with the developers to fix 
> > > any bugs or lack of documentation.
> > 
> > Apparently not even its user<->kernel interface was reviewed. This
> > violates "one value per file in sysfs":
> > 
> >     [root@...oyo]# cat /sys/kernel/security/tomoyo/meminfo
> >     Shared:       61440
> >     Private:      69632
> >     Dynamic:        768
> >     Total:       131840
> >     
> >     You can set memory quota by writing to this file.
> >     (Example)
> >     [root@...oyo]# echo Shared: 2097152 > /sys/kernel/security/tomoyo/meminfo
> >     [root@...oyo]# echo Private: 2097152 > /sys/kernel/security/tomoyo/meminfo
> 
> This is not sysfs, it's securityfs, with their documentation showing it 
> mounted on /sys.

Well, that's a bit better, but it still does not justify turning
securityfs into procfs-like mess... when solution is so easy. Just use
one value per file.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/