linux-kernel - Re: [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2009 19:16:34 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	ideawu <ideawu@....com>
Cc:	"nfsv4@...ux-nfs.org" <nfsv4@...ux-nfs.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server =
	serv;' in svc_process

On Thu, Mar 26, 2009 at 12:55:29PM +0800, ideawu wrote:
> There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.

Thanks!  Applied.

> 
> Signed-off-by: ideawu <ideawu@....com>
> --------
> 
> --- net/sunrpc/svc.c	2009-03-24 07:12:14.000000000 +0800
> +++ net/sunrpc/svc.mod.c	2009-03-26 09:39:15.187500000 +0800

(But next time please make sure the patch applies with 'patch -p1').

--b.

> @@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
>  	procp = versp->vs_proc + proc;
>  	if (proc >= versp->vs_nproc || !procp->pc_func)
>  		goto err_bad_proc;
> -	rqstp->rq_server   = serv;
>  	rqstp->rq_procinfo = procp;
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/