linux-kernel - Re: netrom: zero length frame filtering in NetRom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090328002137.52558018@lxorguk.ukuu.org.uk>
Date:	Sat, 28 Mar 2009 00:21:37 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: netrom: zero length frame filtering in NetRom

On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Alan Cox <alan@...rguk.ukuu.org.uk>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
> 
> > 
> > > +	/* NetRom empty data frame has no meaning : ignore it */
> > > +	if (copied == 0) {
> > > +		goto out;
> > > +	}
> > > +
> > 
> > Also broken - and doesn't follow the coding style either 8)
> 
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)
> 
> I'll back them both out which is what I assume you want me to
> do.

Yes. Handling zero length frames with socket API is nasty and ugly but
unfortunately its a valid use of these protocols. I need to go read the
AF_ROSE docs to double check the situation with ROSE but the other two
definitely want backing out.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/