linux-kernel - Re: [PATCH] iptables: "cluster" match uses IPv6-specific code without ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090329114916.GN15306@prithivi.gnumonks.org>
Date:	Sun, 29 Mar 2009 13:49:16 +0200
From:	Harald Welte <laforge@...filter.org>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	Steven Noonan <steven@...inklabs.net>,
	linux-kernel@...r.kernel.org,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH] iptables: "cluster" match uses IPv6-specific code
	without ifdef

On Fri, Mar 27, 2009 at 01:50:16PM +0100, Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> Patrick McHardy wrote:
>>> Pablo Neira Ayuso wrote:
>>>> Steven Noonan wrote:
>>>>> The symbol __ipv6_addr_type is only available with CONFIG_IPV6 or
>>>>> CONFIG_IPV6_MODULE.
>>>> Please, CC netfilter-devel for netfilter-related issues. Patrick, I'm
>>>> fine with this, can you apply this patch?
>>> Is my reading correct that this won't introduce a module
>>> dependency on IPv6?
>>
>> Hm, this fixes a compilation issue when IPv6 is not enabled. In that
>> case you can still use the cluster match, so I don't see any extra
>> modules dependencies.
>
> That was badly phrased, sorry. The patch of course doesn't change
> anything in that regard.
>
> I'm wondering whether we have a (runtime) dependency on the ipv6
> module due to the ipv6_addr_type() call. If that's the case, it
> would need to be fixed as well.

we don't, see my other mail (linux-next) tree.  It's provided by a function
that is always statically linked into vmlinux.

-- 
- Harald Welte <laforge@...filter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)