linux-kernel - Re: [PATCH 34/58] move omap_rng's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903291203.54301.david-b@pacbell.net>
Date:	Sun, 29 Mar 2009 12:03:53 -0700
From:	David Brownell <david-b@...bell.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	"Uwe Kleine-König" 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Patrick McHardy <kaber@...sh.net>,
	Jan Engelhardt <jengelh@....de>, Michael Buesch <mb@...sch.de>
Subject: Re: [PATCH 34/58] move omap_rng's probe function to .devinit.text

On Sunday 29 March 2009, Herbert Xu wrote:
> On Sat, Mar 28, 2009 at 12:26:55AM +0100, Uwe Kleine-König wrote:
> > A pointer to omap_rng_probe is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> > 
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.

Reminder:  we're expecting such an updated version,
to replace this one.


> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Cc: Russell King <rmk+kernel@....linux.org.uk>
> > Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: Patrick McHardy <kaber@...sh.net>
> > Cc: Jan Engelhardt <jengelh@....de>
> > Cc: Michael Buesch <mb@...sch.de>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> 
> Applied to cryptodev.  Thanks!
> -- 
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/