linux-kernel - Re: [patch 09/35 error-handling] reiserfs: add locking around error buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y6umlud1.fsf@basil.nowhere.org>
Date:	Mon, 30 Mar 2009 20:48:42 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	ReiserFS Development List <reiserfs-devel@...r.kernel.org>
Subject: Re: [patch 09/35 error-handling] reiserfs: add locking around error buffer

Jeff Mahoney <jeffm@...e.com> writes:

>  The formatting of the error buffer is race prone. It uses static buffers
>  for both formatting and output. While overwriting the error buffer
>  can product garbled output, overwriting the format buffer with incompatible
>  % directives can cause crashes.

Really? Just curious but could you describe the steps how a garbled printk can
leads to a crash?

Thanks,

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/