linux-kernel - Re: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090401114557.GC23678@elte.hu>
Date:	Wed, 1 Apr 2009 13:45:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Metzger, Markus T" <markus.t.metzger@...el.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"eranian@...glemail.com" <eranian@...glemail.com>,
	"Villacis, Juan" <juan.villacis@...el.com>,
	"ak@...ux.jf.intel.com" <ak@...ux.jf.intel.com>
Subject: Re: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and
	cleanups


* Metzger, Markus T <markus.t.metzger@...el.com> wrote:

> >-----Original Message-----
> >From: Oleg Nesterov [mailto:oleg@...hat.com]
> >Sent: Wednesday, April 01, 2009 1:40 AM
> >To: Metzger, Markus T
> 
> 
> >> The first 5 patches apply to .29 with the small preparation patch below.
> >
> >Tried to review these patches.
> >
> >As I said, I don't understand ds.c, but I _think_ these changes are good.
> >
> >I only have a couple of really minor nitpicks...
> 
> Thanks for your review!
> I will address the nitpicks in separate patches, if that's OK with everyone.

Please dont forget to propagate Oleg's Reviewed-by (or Acked-by) 
tags into the commits.

> Regarding bisecting, I split the patches to attract reviewers to 
> the smaller parts rather than scare them off with one big patch.
>
> I hope that the bisecting tool can cope with broken builds between 
> patches.

It cannot, and even if it did we dont want a single intentionally 
broken bisection point in the kernel. Please do small patches that 
build fine at each step. We've got more than 100,000 bisectable 
commits in the kernel to look at. If you think it's not possible in 
a specific case then please describe the situation to us so that we 
can suggest a solution.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/