linux-kernel - RE: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77E926D539D@irsmsx504.ger.corp.intel.com>
Date:	Wed, 1 Apr 2009 13:56:58 +0100
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Oleg Nesterov <oleg@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"eranian@...glemail.com" <eranian@...glemail.com>,
	"Villacis, Juan" <juan.villacis@...el.com>,
	"ak@...ux.jf.intel.com" <ak@...ux.jf.intel.com>
Subject: RE: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and
	cleanups

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@...e.hu]
>Sent: Wednesday, April 01, 2009 1:46 PM
>To: Metzger, Markus T


>> >> The first 5 patches apply to .29 with the small preparation patch below.
>> >
>> >Tried to review these patches.
>> >
>> >As I said, I don't understand ds.c, but I _think_ these changes are good.
>> >
>> >I only have a couple of really minor nitpicks...
>>
>> Thanks for your review!
>> I will address the nitpicks in separate patches, if that's OK with everyone.
>
>Please dont forget to propagate Oleg's Reviewed-by (or Acked-by)
>tags into the commits.
>
>> Regarding bisecting, I split the patches to attract reviewers to
>> the smaller parts rather than scare them off with one big patch.
>>
>> I hope that the bisecting tool can cope with broken builds between
>> patches.
>
>It cannot, and even if it did we dont want a single intentionally
>broken bisection point in the kernel. Please do small patches that
>build fine at each step. We've got more than 100,000 bisectable
>commits in the kernel to look at. If you think it's not possible in
>a specific case then please describe the situation to us so that we
>can suggest a solution.

I can resend the series with fewer but bigger patches that compile OK.

I'm currently using quilt to manage patches.
I use git to get the sources, but that's it. I send all the patches manually.

You mentioned in another email that I should use "git format-patch" and
"git send-email" and that I should propagate Oleg's acks into the commit
logs.

Is there a way to do this with quilt, as well?
Could you point me to some getting-started documentation?


thanks and regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/