linux-kernel - Re: 2.6.29-git: cannot mount ext4/loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D4F044.1040306@ph.tum.de>
Date:	Thu, 02 Apr 2009 19:05:08 +0200
From:	Thiemo Nagel <thiemo.nagel@...tum.de>
To:	Theodore Tso <tytso@....edu>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Jens Axboe <jens.axboe@...cle.com>, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.29-git: cannot mount ext4/loop

Theodore Tso wrote:
> On Thu, Apr 02, 2009 at 05:18:39PM +0200, Thiemo Nagel wrote:
>> Theodore Tso wrote:
>>> On Thu, Apr 02, 2009 at 03:30:26PM +0200, Thiemo Nagel wrote:
>>>> When I added the block range checks, initially I was assuming that
>>>> when EXTENTS_FL is not set, the inode->i_data *always* contains
>>>> references to further blocks.  Ted showed me wrong and added the condition
>>>>
>>>> 	ISREG() || ISDIR() || ( ISLNK() && !is_fast_symlink() )
>>>>
>>>> before that assumption can be made.  But maybe we need some further
>>>> restraints?
>>> It's a endian-problem; we're missing le32_to_cpu() in that patch.
>>> Sparc is big-endian. 
>> Sorry for that.
> 
> Could you also fix the types?  bref should have a type of __le32, not
> unsigned int, and when you pass in the reference to
> __ext4_check_blockref(), there was an inappropriate cast to unsigned
> int which hid kernel's natural type checking to catch these sorts of
> problems.

So I was really asking for things to go wrong...  :-(
I hope the attached patch handles conversion and types in the right way. 
  It's compile-tested only, the current ext4 tree crashes my machine.

Kind regards,

Thiemo

View attachment "le32_fix" of type "text/plain" (1286 bytes)