linux-kernel - Re: [PATCH 23/43] CacheFiles: Permit the page lock state to be monitored [ver #46]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Apr 2009 18:05:07 +0100
From:	David Howells <dhowells@...hat.com>
To:	Nick Piggin <nickpiggin@...oo.com.au>
Cc:	dhowells@...hat.com, viro@...iv.linux.org.uk, nfsv4@...ux-nfs.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 23/43] CacheFiles: Permit the page lock state to be monitored [ver #46]

Nick Piggin <nickpiggin@...oo.com.au> wrote:

> Presumably: at the point where data is needed.

But the point where the data is needed is where filemap.c is waiting on a
netfs page.  Maybe the sync_page() aop can deal with it

There's also the problem of recording and pinning the backing page I'm waiting
for.  Currently I can do that by hooking the monitor block into the page
unlock watching list.  If I don't do that, I have to use up yet more memory to
track those some other way.  It's not impossible, but I'd like to keep memory
usage down.

> Or do you actually have numbers showing a problem if you just read the pages
> then copy them?

I did, years ago.  It wasn't particularly good, but
fscache_read_or_alloc_pages() was completely synchronous.

> If there is a problem, then why doesn't fscache_read_or_alloc_pages caller
> do the work itself, then you get as many threads as you have indivisible
> work units, so completing some part of the request before another wouldn't
> gain you anything anyway...

(1) Trond stipulated FS-Cache had to be asynchronous, and it is, as far as I
    can make it.  I still have to invoke bmap() synchronously, though, to find
    out whether I have a page in the cache to read:-/

(2) You lose the advantage of being able to process what you've got whilst the
    disk is fetching stuff in the background.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/