linux-kernel - Re: [BUG][-tip] kprobes on module functions hits kernel BUG in text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D82A52.8050808@redhat.com>
Date:	Sat, 04 Apr 2009 23:49:38 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Ingo Molnar <mingo@...e.hu>
CC:	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	systemtap-ml <systemtap@...rces.redhat.com>
Subject: Re: [BUG][-tip] kprobes on module functions hits kernel BUG in 	text_poke
    on x86-32

Masami Hiramatsu wrote:
> Hmm, ok. AFAICS, fixmap is only for lowmem, and pkmap is only for highmem.

Oops, I mean kmap...


> So, I think we have some options;
> 
> A) Separate text_poke into __text_poke and __text_poke_highmem. And
>   use pkmap_atomic in __text_poke_highmem. This way doesn't require
>   any additional change except adding KM_TEXT_POKE0/1 in km_type.
> 
> B) Add set_fixmap_page and use it in text_poke. This will require
>   changes in paravirt_ops and pgtable.c. We need to ensure there is
>   no side effects.
> 
> C) Change pkmap_atomic_prot to map lowmem only if the page's pgprot
>   is different from user specified pgprot. And use it instead of
>   fixmap. This also requires KM_TEXT_POKE0/1, however we can
>   remove FIX_TEXT_POKE0/1.

same, s/pkmap/kmap/g


-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/