linux-kernel - Re: [PATCH] drivers/mmc/core/core.c: extend limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090405205727.7a86d61b@mjolnir.ossman.eu>
Date:	Sun, 5 Apr 2009 20:57:27 +0200
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Frans Meulenbroeks <fransmeulenbroeks@...il.com>
Cc:	linux-kernel@...r.kernel.org, beagleboard@...glegroups.com,
	openembedded-devel@...ts.openembedded.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH] drivers/mmc/core/core.c: extend limit

On Wed, 25 Mar 2009 23:03:28 +0100 (CET)
Frans Meulenbroeks <fransmeulenbroeks@...il.com> wrote:

> 
> This did not help me as the limit was already at 300000. However, I 
> decided to raise the limit to 500000. Still no go so I also doubled the 
> read limit from 100000 to 200000. After that the cards work without 
> problem. Changing the write timing back to 300000 brought the problem back 
> so apparently both timings need to be extended. Attached is the patch I 
> used for this. As it is a timeout limit value, it should not harm anyone, 
> and a longer timeout at least allows more cards to be used.
> 

Unfortunately some controllers cannot cope with huge timeouts and will
complain. And such a huge timeout shouldn't be needed (and they weren't
any larger in .27).

> 
> What somewhat troubles me is that this worked in .27, so it might be this 
> patch does not address the root cause. Then again this is the best I can 
> do. If someone has a better solution, I am more than happy to test it.
> 

Indeed. Have you enabled MMC_DEBUG and checked that the controller
actually follows the configured timeouts?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/