linux-kernel - Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit() in filter_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2009 10:56:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Tom Zanussi <tzanussi@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>, fweisbec@...il.com
Subject: Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit()
	in filter_check_discard()


* Ingo Molnar <mingo@...e.hu> wrote:

> * Tom Zanussi <tzanussi@...il.com> wrote:
> 
> > This patch changes filter_check_discard() to make use of the new 
> > ring_buffer_discard_commit() function and modifies the current 
> > users to call the old commit function in the non-discard case.  It 
> > also introduces a version of filter_check_discard() that uses the 
> > global trace buffer (filter_current_check_discard()) for those 
> > cases.
> > 
> > v2 changes:
> > 
> > - fix compile error noticed by Ingo Molnar
> > 
> > Signed-off-by: Tom Zanussi <tzanussi@...il.com>
> 
> Thanks Tom, i've applied it to tip:tracing/filters and i've started 
> testing it.

still has build failures:

kernel/built-in.o: In function `filter_check_discard':
trace.c:(.text+0x5b057): undefined reference to `filter_match_preds'
kernel/built-in.o: In function `trace_vprintk':
(.text+0x5b200): undefined reference to `event_print'
kernel/built-in.o: In function `trace_vbprintk':
(.text+0x5b447): undefined reference to `event_bprint'
kernel/built-in.o: In function `__ftrace_trace_stack':
trace.c:(.text+0x5b503): undefined reference to `event_kernel_stack'
kernel/built-in.o: In function `ftrace_trace_userstack':
trace.c:(.text+0x5b5b8): undefined reference to `event_user_stack'
kernel/built-in.o: In function `tracing_sched_wakeup_trace':
(.text+0x5b62f): undefined reference to `event_wakeup'
kernel/built-in.o: In function `trace_function':
(.text+0x5b719): undefined reference to `event_function'
kernel/built-in.o: In function `tracing_sched_switch_trace':
(.text+0x5c51f): undefined reference to `event_context_switch'
make: *** [.tmp_vmlinux1] Error 1

Please send a delta fix against tip/tracing/filters - thanks.

Config attached.

	Ingo

View attachment "config" of type "text/plain" (64670 bytes)